Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pho does not support inheritance #17

Open
ssiddiqu opened this issue Jun 24, 2017 · 1 comment
Open

Pho does not support inheritance #17

ssiddiqu opened this issue Jun 24, 2017 · 1 comment

Comments

@ssiddiqu
Copy link

I created a class hierarchy and when saving an object of the subclass, it does not actually set the values for the columns that correspond to the attributes of the super class. The issue is in the following line:
com.eharmony.pho.mapper.EntityPropertiesMappingContext
private Set buildEntityPropertiesSet(Class<? extends Object> clz, String parentProperty) {

Set<EntityPropertyBinding> entityPropertiesSet = new HashSet<EntityPropertyBinding>();

133 Field[] fields = clz.getDeclaredFields();
Because it uses getDeclaredFields is only sees the fields in the current class. This should be using getFields().

@vvangapandu
Copy link
Contributor

Hi @ssiddiqu thanks for looking into this, please provide a pull request with changes. will review the PR and merge it to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants