From d53551689e46dcfe4e5510f7947b8848b2f29f39 Mon Sep 17 00:00:00 2001 From: Patrick Gagnon-Renaud Date: Wed, 10 Feb 2021 16:22:57 -0500 Subject: [PATCH] Do not fix buildFingerprint() method --- src/ConfigEnvironment.php | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/ConfigEnvironment.php b/src/ConfigEnvironment.php index 83f4b83..e8a1771 100644 --- a/src/ConfigEnvironment.php +++ b/src/ConfigEnvironment.php @@ -98,7 +98,16 @@ public function getReleasePath($release, $path = '') */ public function buildFingerprint() { - return sha1($this->get('server') . $this->get('deploy_path')); + // This method should have computed an hash combining the server + // string and the deploy path (see the line bellow), but I forgot to + // fix this method when splitting 'server' into 'ssh_user' and + // 'ssh_host'. Since fixing this would cause issue with all existing + // cronjobs and not fixing this does not, I'm leaving this comment + // as an explanation why I did not fix it and left it as-is. + // + // return sha1($this->get('ssh_user') . '@' . $this->get('ssh_host') . ':' . $this->get('deploy_path')); + + return sha1($this->get('deploy_path')); } /**