Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"getEntry_" should use the "opt_errorHandler" passed by "Filer.prototype.open" #33

Open
bux opened this issue Jul 5, 2013 · 1 comment

Comments

@bux
Copy link

bux commented Jul 5, 2013

You can't handle the error when the file you are trying to open does not exist.

@beccasaurus
Copy link

I just ran into this issue and sent a pull request (including updated method documentation and a test)

I noticed that there's also an existing pull request to fix this bug so that should also be closed. Note: that implementation is undocumented and untested but the same test could be used if that pull request's implementation is preferred.

For getEntry_ I followed the existing convention of ending the method signature with opt_errorHandler. I also followed the pattern of checking for opt_errorHandler else throw(e).

sarim added a commit to sarim/filer.js that referenced this issue Sep 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants