Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Util class #57

Open
soullivaneuh opened this issue Jan 5, 2016 · 3 comments
Open

Rename Util class #57

soullivaneuh opened this issue Jan 5, 2016 · 3 comments

Comments

@soullivaneuh
Copy link

Util is a too generic name for a class and can have conflicts with other libraries.

I would suggest you to rename it on a new major version.

FilerUtil sounds better IMHO.

Regards.
@ebidel
Copy link
Owner

ebidel commented Jan 5, 2016

Want to send a PR?

@soullivaneuh
Copy link
Author

Just tell me if I have to care with the minified version of the library and how and I will do that with pleasure. 👍

@ebidel
Copy link
Owner

ebidel commented Jan 5, 2016

Changing source is fine. I can do a new build and release. Thanks!

ps. make sure to update tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebidel @soullivaneuh