Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor validation of OptionField #8

Open
halphy opened this issue Apr 26, 2023 · 3 comments
Open

refactor validation of OptionField #8

halphy opened this issue Apr 26, 2023 · 3 comments

Comments

@halphy
Copy link
Contributor

halphy commented Apr 26, 2023

現時点では OptionField のバリデーション処理を OptionsPane クラス内の _get_options() メソッド内で行なっていますが、実装を分散させないためにもこれは各 OptionField クラス内のメソッドに書くべきだと考えます。
@ebiyu
Copy link
Owner

ebiyu commented Apr 26, 2023

バリデーション処理はUIによって変わると思うので難しい
例えばstrで来るのか、intで来るのか など

@ebiyu
Copy link
Owner

ebiyu commented Apr 26, 2023

UIの種類*OptionFieldの種類だけ処理が出てくる

@halphy
Copy link
Contributor Author

halphy commented Apr 26, 2023

確かに、どうやっても幸せにはなれなさそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebiyu @halphy