Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notify) add lsp progress formatter #1276

Conversation

KaspervdHeijden
Copy link

@KaspervdHeijden KaspervdHeijden commented Oct 13, 2024

Fixes #1275

@KaspervdHeijden
Copy link
Author

The formatted string will still be post processed by config.content.format. An argument could be made that this added layer could instead be added/merged into config.content.format. Chose to not do that since it is more work:

  • Add type to the MiniNotify-specification object
  • Make MiniNotify.default_format() aware
  • Update documentation
  • Make sure it does not break existing users configurations

@echasnovski
Copy link
Owner

Thanks for the PR!

Adding new option specifically for formatting LSP progress definitely does not fit in 'mini.nvim' design. There is a config.content.format and it should be able to be used for this. If no good way to do this, then I am afraid the only way to do this will be manually overriding vim.lsp.handlers['$/progress'].

Now, the only missing part for a more straightforward adoption is indeed some type of source field for notification. Maybe adding to specification is the right thing to do.

In any case, I'll close this PR and will think a bit more about this. Thanks again for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add format function for LSP progress
2 participants