Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply some clippy lint where it makes sense #226

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Apply some clippy lint where it makes sense #226

merged 1 commit into from
Jun 8, 2024

Conversation

ptondereau
Copy link
Contributor

No big deals here, and just applying some clippy rules that make sense.
Please don't hesitate to close if it's not relevant

Copy link

codspeed-hq bot commented Jun 8, 2024

CodSpeed Performance Report

Merging #226 will not alter performance

Comparing ptondereau:clippy-hunt (9043f42) with main (71f4350)

Summary

✅ 12 untouched benchmarks

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 51.51515% with 16 lines in your changes missing coverage. Please review.

Project coverage is 67.51%. Comparing base (71f4350) to head (9043f42).

Files Patch % Lines
biscuit-auth/src/token/builder.rs 16.66% 5 Missing ⚠️
biscuit-quote/src/lib.rs 0.00% 4 Missing ⚠️
biscuit-auth/src/token/authorizer.rs 66.66% 3 Missing ⚠️
biscuit-auth/src/datalog/mod.rs 83.33% 1 Missing ⚠️
biscuit-auth/src/datalog/symbol.rs 50.00% 1 Missing ⚠️
biscuit-auth/src/format/convert.rs 0.00% 1 Missing ⚠️
biscuit-auth/src/token/authorizer/snapshot.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   67.47%   67.51%   +0.03%     
==========================================
  Files          25       25              
  Lines        5347     5347              
==========================================
+ Hits         3608     3610       +2     
+ Misses       1739     1737       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Geal Geal merged commit c2618db into eclipse-biscuit:main Jun 8, 2024
6 of 7 checks passed
@Geal
Copy link
Contributor

Geal commented Jun 8, 2024

thanks!

@ptondereau ptondereau deleted the clippy-hunt branch June 8, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants