Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default binary file folder #1131

Closed
CsCherrYY opened this issue Jan 6, 2022 · 2 comments
Closed

Default binary file folder #1131

CsCherrYY opened this issue Jan 6, 2022 · 2 comments

Comments

@CsCherrYY
Copy link
Contributor

CsCherrYY commented Jan 6, 2022

It seems the default behavior of buildship is to generate .class files in bin folder of the project (maybe it related to some Eclipse configurations), but for Gradle users, they might be familiar with build folder. There are some requests related to this issue:

Now I can still reproduce this in both the newest eclipse and VS Code. A workaround can be found here: redhat-developer/vscode-java#634 (comment). But we can't make build as the default binary output folder by default. I'm not sure there if there is anything we can do at buildship side to make the user experience better. @donat could you provide any comments?

@donat
Copy link
Contributor

donat commented Jan 17, 2022

I understand the intent, but I don't think it's a good idea. There's a reason why Eclipse and Gradle do not share their build folders. If those directories would be shared:

  • The JDT editor support could be easily be broken by deleting the class files (generated by ejc) with a simple gradle clean command.
  • Many Gradle features (up-to-date checks, cache hits, compile avoidance, etc) could be busted if JDT would write classes to the Gradle build directory.

@mkq
Copy link

mkq commented Dec 7, 2022

I agree that Eclipse and Gradle output directories should be separate, but Buildship should honor Window / Preferences / Java / Build Path / Output folder name (whether the user sets it to "build" if he's adventurous or whatever).

Can we reopen this issue or should I open a new one? redhat-developer/vscode-java#1615 (mentioned in redhat-developer/vscode-java#2801 in turn mentioned above) seems close, but is about VSCode. Maybe a Buildship specific option makes sense there, but in Eclipse, the obvious Buildship Default would be to use the Eclipse preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants