Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace server does not use trace selection signals #1003

Open
arfio opened this issue Jul 28, 2023 · 1 comment
Open

Trace server does not use trace selection signals #1003

arfio opened this issue Jul 28, 2023 · 1 comment
Labels
Trace Compass Involve changes in the main Trace Compass repo

Comments

@arfio
Copy link
Contributor

arfio commented Jul 28, 2023

The server does not broadcast any trace selected signal as you can have multiple opened traces at the same time and it should be possible to request data of an already opened experiment.
The selected trace signal is only used in the core projects to register the parameter providers. This registration also happens when the trace is opened, however the order in which the trace opened signals are handled is random, and because there is only one parameter provider instance, the analysis which is registered is random.
A couple of solutions are possible:

  • Selecting the trace before providing a parameter (can maybe cause some race conditions)
  • Having one parameter provider per trace, and then filtering in the handler with the correct trace.
  • Creating a different mechanism to provide parameters for the few analyses that uses them.
@marco-miller marco-miller added the Trace Compass Involve changes in the main Trace Compass repo label Jul 28, 2023
@bhufmann
Copy link
Collaborator

bhufmann commented Aug 8, 2023

In Eclipse Trace Compass the TmfTraceSelectedSignal is broadcasted when a user opens or selects a trace from multiple open traces. The receiver of the signal are in most case the view components which is used to update the views. I wasn't aware that is also used for the parameter provider. Looking at the the parameter providers implementations in Eclipse Trace Compass, most are implemented in the UI components as well. To use these parameter providers, the code has to be refactored and brought into the core components without UI. This doesn't solve the fact that that signal is not broadcasted when using the trace server.

I wonder if it could be send right after the place where the TmfTraceOpendedSignal is sent?

Having said that, I would suggest to use one use case (I think you're looking into the critical path parameter provider) to come-up how it can be implemented using the parameter providers.

I hope, the code can be done in such way that it can be used in Eclipse and Trace Server without re-implementing it.

Please keep us in the loop and let us know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trace Compass Involve changes in the main Trace Compass repo
Projects
None yet
Development

No branches or pull requests

3 participants