Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ColumnDescriptor structure and usage #39

Open
bhufmann opened this issue Oct 20, 2021 · 0 comments
Open

Remove ColumnDescriptor structure and usage #39

bhufmann opened this issue Oct 20, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@bhufmann
Copy link
Collaborator

The ColumnDescriptor data structure (column_descriptor.py) was introduced to support the server-side equivalent data structure which has been serialized in the tree structure by the Trace Compass trace server. However, this was an undocumented and Trace Compass internal data structure. The serialization was removed to align with the TSP specification. After that it's no longer available on the client and cannot be acted on.

In implementation of option --get-tree, the column descriptor is used to print the header information of each column. Since it's not available anymore the header is not printed anymore.

When removing this data structure in the client, the print-out (TreeModel.print()) needs to be fixed as well to print the header information which is provided differently now.

@bhufmann bhufmann added the bug Something isn't working label Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant