Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Inspector context menu enhancements #51

Closed
5 tasks done
jreineckearm opened this issue Dec 8, 2023 · 4 comments
Closed
5 tasks done

Memory Inspector context menu enhancements #51

jreineckearm opened this issue Dec 8, 2023 · 4 comments
Assignees
@tortmayr @martin-fleck-at

Comments

@jreineckearm
Copy link
Contributor

jreineckearm commented Dec 8, 2023 •
edited by colin-grant-work
Loading

Description

The current Memory Inspector context menu seems to be the standard context menu. It would be very useful to utilize it for a couple of usability enhancements.

Additional information
@tortmayr tortmayr self-assigned this Feb 14, 2024
@tortmayr tortmayr mentioned this issue Feb 27, 2024
Open
tortmayr added a commit to eclipsesource/vscode-memory-inspector that referenced this issue Mar 5, 2024
@tortmayr
Context menu enhancements
d06ecec 
Enhances the memory webview to  properly support context menu actions contributed via `webview/context` contribution point. This includes
- Augmenting the webview components with `data-vscode-context` custom data properties.
 These properties are used to provide additional context info (as JSON string). The composed context is then available in `when` conditions from `webview/context` contributions and as command argument when executing the associated command.

Provides the following context menu enhancements outlined in eclipse-cdt-cloud#51
- Copy selection
- Quick access to window configuration by
  - providing show/hide entries for variable & ascii column
  - show/hide for radix prefix
  - `Show advanced Options` command to show the advanced settings overlay
 - Allow contributions from other extensions
@tortmayr tortmayr mentioned this issue Mar 5, 2024
Merged
1 task
@tortmayr
Copy link
Contributor

tortmayr commented Mar 5, 2024

The following is covered by #94

  • Copy selection
  • Quick access to memory window configurations
  • Allow contributions from other extensions, for example to send selected data to other views

(I cannot update the original issue description)

tortmayr added a commit to eclipsesource/vscode-memory-inspector that referenced this issue Mar 6, 2024
@tortmayr
Context menu enhancements
36a5d1e 
Enhances the memory webview to  properly support context menu actions contributed via `webview/context` contribution point. This includes
- Augmenting the webview components with `data-vscode-context` custom data properties.
 These properties are used to provide additional context info (as JSON string). The composed context is then available in `when` conditions from `webview/context` contributions and as command argument when executing the associated command.

Provides the following context menu enhancements outlined in eclipse-cdt-cloud#51
- Copy selection
- Quick access to window configuration by
  - providing show/hide entries for variable & ascii column
  - show/hide for radix prefix
  - `Show advanced Options` command to show the advanced settings overlay
 - Allow contributions from other extensions
tortmayr added a commit to eclipsesource/vscode-memory-inspector that referenced this issue Mar 6, 2024
@tortmayr
Context menu enhancements
cf40382 
Enhances the memory webview to  properly support context menu actions contributed via `webview/context` contribution point. This includes
- Augmenting the webview components with `data-vscode-context` custom data properties.
 These properties are used to provide additional context info (as JSON string). The composed context is then available in `when` conditions from `webview/context` contributions and as command argument when executing the associated command.

Provides the following context menu enhancements outlined in eclipse-cdt-cloud#51
- Copy selection
- Quick access to window configuration by
  - providing show/hide entries for variable & ascii column
  - show/hide for radix prefix
  - `Show advanced Options` command to show the advanced settings overlay
 - Allow contributions from other extensions
tortmayr added a commit to eclipsesource/vscode-memory-inspector that referenced this issue Mar 7, 2024
@tortmayr
Context menu enhancements
e05a90d 
Enhances the memory webview to  properly support context menu actions contributed via `webview/context` contribution point. This includes
- Augmenting the webview components with `data-vscode-context` custom data properties.
 These properties are used to provide additional context info (as JSON string). The composed context is then available in `when` conditions from `webview/context` contributions and as command argument when executing the associated command.

Provides the following context menu enhancements outlined in eclipse-cdt-cloud#51
- Quick access to window configuration by
  - providing show/hide entries for variable & ascii column
  - show/hide for radix prefix
  - `Show advanced Options` command to show the advanced settings overlay
 - Allow contributions from other extensions
tortmayr added a commit to eclipsesource/vscode-memory-inspector that referenced this issue Mar 8, 2024
@tortmayr
Context menu enhancements
43b5073 
Enhances the memory webview to  properly support context menu actions contributed via `webview/context` contribution point. This includes
- Augmenting the webview components with `data-vscode-context` custom data properties.
 These properties are used to provide additional context info (as JSON string). The composed context is then available in `when` conditions from `webview/context` contributions and as command argument when executing the associated command.

Provides the following context menu enhancements outlined in eclipse-cdt-cloud#51
- Quick access to window configuration by
  - providing show/hide entries for variable & ascii column
  - show/hide for radix prefix
  - `Show advanced Options` command to show the advanced settings overlay
 - Allow contributions from other extensions
colin-grant-work pushed a commit that referenced this issue Mar 11, 2024
@tortmayr
Context menu enhancements (#94)
68ad5ca 
* Context menu enhancements

Enhances the memory webview to  properly support context menu actions contributed via `webview/context` contribution point. This includes
- Augmenting the webview components with `data-vscode-context` custom data properties.
 These properties are used to provide additional context info (as JSON string). The composed context is then available in `when` conditions from `webview/context` contributions and as command argument when executing the associated command.

Provides the following context menu enhancements outlined in #51
- Quick access to window configuration by
  - providing show/hide entries for variable & ascii column
  - show/hide for radix prefix
  - `Show advanced Options` command to show the advanced settings overlay
 - Allow contributions from other extensions
@planger planger mentioned this issue Mar 12, 2024
Open
@martin-fleck-at martin-fleck-at mentioned this issue Mar 12, 2024
Merged
1 task
@planger planger closed this as completed Mar 18, 2024
@planger planger reopened this Mar 18, 2024
@planger
Copy link
Contributor

planger commented Mar 18, 2024

@martin-fleck-at Can this issue be already closed? I think all linked PRs are merged, aren't they?

@martin-fleck-at
Copy link
Contributor

@planger Yes, I think it can. I'm just not allowed to check the items in the description ;-)

@colin-grant-work
Copy link

Fixed by #94 and #96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

@martin-fleck-at martin-fleck-at

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@planger @tortmayr @martin-fleck-at @jreineckearm @colin-grant-work