Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh button appearing when it isn't enabled #1044

Closed
jonahgraham opened this issue Jan 17, 2025 · 1 comment · Fixed by #1045
Closed

Refresh button appearing when it isn't enabled #1044

jonahgraham opened this issue Jan 17, 2025 · 1 comment · Fixed by #1045
Assignees
@jonahgraham

Comments

@jonahgraham
Copy link
Member

The refresh button is not supposed to be visible unless explicitly turned on by the user, see the FAQ entry for example: https://github.com/eclipse-cdt/cdt/blob/main/FAQ/README.md#must-the-debugging-views-refresh-automatically

However, last week I submitted #974 and it looks that caused the refresh button to be visible always, I am not quite sure how yet, but I am going to try to fix that so it achieves the desired effect.

Note this is a regression since CDT 11.6 introduced by #974
@jonahgraham jonahgraham self-assigned this Jan 17, 2025
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Jan 17, 2025
@jonahgraham
Restore the empty activity IDs
0f6e39c 
In eclipse-cdt#974 I removed activities we were not using anymore, but it turns
out if LaunchUtils.enableActivity is called on a removed id, strange
things happen, such as other activities incorrectly being enabled.
This may be a bug in platform, or just undefined behavior. But because
extenders do have calls to LaunchUtils.enableActivity in their code,
leave the empty activity ids behind.

Fixes eclipse-cdt#1044
This was referenced Jan 17, 2025
Merged
Closed
@jonahgraham
Copy link
Member Author

It turns out that it isn't just the refresh button getting enabled, this regression could cause all activities to be enabled across the whole platform. See #1045 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonahgraham jonahgraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore the empty activity IDs jonahgraham/cdt
1 participant
@jonahgraham