Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple KeyPairResource ID from keyID #368

Closed
paullatzelsperger opened this issue Jun 5, 2024 · 0 comments · Fixed by #369
Closed

Decouple KeyPairResource ID from keyID #368

paullatzelsperger opened this issue Jun 5, 2024 · 0 comments · Fixed by #369
Assignees
Labels
api enhancement New feature or request

Comments

@paullatzelsperger
Copy link
Member

Feature Request

Currently we use KeyPairResource#id and KeyPairResource#keyId almost interchangeably. This is not good, because it prevents having multiple KeyPairResource objects with the same keyId.

This gets problematic when the database is supposed to contain multiple KeyPairResource objects with the same keyID, but possibly different status flags (rotation, revocation,...). That would cause conflicts.

Which Areas Would Be Affected?

KeyPairResource API + underlying layers

Why Is the Feature Desired?

KeyPairResource#id is the data base ID, which should be decoupled from the keyId.

Solution Proposal

  • add an optional resourceId field to the KeyDescriptor, that - if set - determines the KeyPairResource#id. If left blank, a random UUID is used.
  • adding KeyPairResources through the API follows the same scheme
@paullatzelsperger paullatzelsperger added api enhancement New feature or request labels Jun 5, 2024
@paullatzelsperger paullatzelsperger self-assigned this Jun 5, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label Jun 5, 2024
@paullatzelsperger paullatzelsperger removed the triage all new issues awaiting classification label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant