Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate ParticipantContext in an explicit step #455

Closed
paullatzelsperger opened this issue Sep 12, 2024 · 0 comments · Fixed by #457
Closed

Activate ParticipantContext in an explicit step #455

paullatzelsperger opened this issue Sep 12, 2024 · 0 comments · Fixed by #457
Assignees
Labels
enhancement New feature or request

Comments

@paullatzelsperger
Copy link
Member

Feature Request

When the ParticipantContext is created, and its active flag is set, it must still be created int he inactive state, to avoid the DID publication.

Then, after all the keys are added (and possibly activated), the ParticipantContext is activated in an explicit step by the ParticipantContextCoordinator

Which Areas Would Be Affected?

ParticipantContextCoordinator

Why Is the Feature Desired?

if the ParticipantContext is created in the active state, adding (and activating) keypairs will lead to another DID publication, and then, later, the ParticipantContextCoordinator would publish yet again.
Creating the ParticipantContext in the inactive state will avoid the first publication.

Solution Proposal

  • always create the ParticipantContext in the inactive state
  • ParticipantContextCoordinator updates the DID document, adds keypairs, (possibly activates keypairs) and then explicitly activates the ParticipantContext, if the flag was set in the ParticipantManifest.
  • ParticipantContextCoordinator publishes the DID Document. here, the manifest.isActive() check is not needed anymore.
@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Sep 12, 2024
@paullatzelsperger paullatzelsperger self-assigned this Sep 12, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label Sep 12, 2024
@paullatzelsperger paullatzelsperger removed the triage all new issues awaiting classification label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant