Issues with classes starting with $

[snjeza]

Related issues

• call hierarchy does not find callers (but it should) redhat-developer/vscode-java#2219
• generated-sources/java is not picked up as a source path redhat-developer/vscode-java#1639 (comment)

Steps to reproduce:

• create the $EnumUtils.java class

package org.sample;
public class $EnumUtils {
	public void test() {
	}
}

• create the Main.java class

package org.sample.main;
public class Main {
	public static void main(String[] args) {
		$EnumUtils foo = new $EnumUtils();
	}
}

• try CA, Organize Import, Search, Open Type

[szarnekow]

Any chance we can find a holistic solution that also supports the following cases for top-level types?

• MyClass$
• MyClass$$$Generated

It would also be interesting to check if these naming patterns can be supported for nested classes, too.

[snjeza]

Any chance we can find a holistic solution that also supports the following cases for top-level types?
MyClass$
MyClass$$$Generated

I have solved them.

It would also be interesting to check if these naming patterns can be supported for nested classes, too.

It should already work.

[stephan-herrmann]

I haven't looked at the details but this issue reminds me of previous bugs, where the bottom line was: for binary types the problem does not have a valid solution (e.g., requesting a '.' separated signature from "MyClass$$$Generated" has 4 valid solutions - no way the implementation can know, which one is "correct").

Hence my question: can you @snjeza explain your strategy in plain words?

Given that class Signature is API, any changes here will affect clients, some of which may have their own heuristics in place, which could possibly break even by changes that are "morally correct".

[snjeza]

Hence my question: can you @snjeza explain your strategy in plain words?

• $ becomes $; it certainly isn't anonymous or nested; the current JDK resolves it as <ClassName>.
• $ becomes $<ClassName}; it certainly isn't anonymous or nested; the current JDK resolves it as .<ClassName>
• MyClass$$$Generated/MyClass$$Generated becomes MyClass$$$Generated/MyClass$$Generated; I agree that it's ambiguous; current JDK resolves it as MyClass...Generated/MyClass..Generated.

I can remove the solution for MyClass$$$Generated or create a minimal PR to fix the issue described at redhat-developer/vscode-java#2219 as follows:

diff --git a/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/BinaryType.java b/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/BinaryType.java
index 6215244b44..0b05d3bf4d 100644
--- a/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/BinaryType.java
+++ b/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/BinaryType.java
@@ -268,7 +268,7 @@ public IType getDeclaringType() {
                                lastDollar = i;
                        }
                }
-               if (lastDollar == -1) {
+               if (lastDollar <= 0) {
                        return null;
                } else {
                        String enclosingName = classFileName.substring(0, lastDollar);

@stephan-herrmann @szarnekow @rgrunber Could you, please, advice?