Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23] Markdown is not rendered when \r and \n are code in unicode #1787

Open
jarthana opened this issue Nov 8, 2024 · 0 comments · May be fixed by #1850
Open

[23] Markdown is not rendered when \r and \n are code in unicode #1787

jarthana opened this issue Nov 8, 2024 · 0 comments · May be fixed by #1850
Assignees
@jjohnstn
Labels
bug Something isn't working
Milestone
4.35 M2

Comments

@jarthana
Copy link
Member

jarthana commented Nov 8, 2024

This was originally raised in 3239
The jdt.core part has been addressed. The UI, where the rendering to HTML happens has to handle the unicode characters to create the correct HTML content.

The markdown comment is this:
/// Unicode in markdown \u000A///\u000D///\u000D\u000A///here

And this is the HTML created by JavadocContentAccess2.getHTMLContent():
Unicode in markdown \u000A/// \u000D/// \u000D\u000A/// here

Javadoc from JDK creates this:

<div class="block"><p>Unicode in markdown</p>
<p>here</p>
</div>
@jarthana jarthana mentioned this issue Nov 8, 2024
Closed
@jjohnstn jjohnstn self-assigned this Dec 12, 2024
@jjohnstn jjohnstn added the bug Something isn't working label Dec 12, 2024
@jjohnstn jjohnstn added this to the 4.35 M1 milestone Dec 12, 2024
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue Dec 12, 2024
@jjohnstn
Support unicode characters in markdown comments
b0dfa71 
- convert unicode chars in CoreMarkdownAccessImpl.removeDocLineIntros()
- add new test to MarkdownCommentTests
- fixes eclipse-jdt#1787
@jjohnstn jjohnstn linked a pull request Dec 12, 2024 that will close this issue
Open
3 tasks
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue Dec 14, 2024
@jjohnstn
Support unicode characters in markdown comments
acea8e3 
- convert unicode chars in CoreMarkdownAccessImpl.removeDocLineIntros()
- add new test to MarkdownCommentTests
- fixes eclipse-jdt#1787
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue Dec 16, 2024
@jjohnstn
Support unicode characters in markdown comments
8e6006b 
- convert unicode chars in CoreMarkdownAccessImpl.removeDocLineIntros()
- add new test to MarkdownCommentTests
- fixes eclipse-jdt#1787
@jjohnstn jjohnstn moved this to Pending review in Java Tooling Jan 8, 2025
@jjohnstn jjohnstn modified the milestones: 4.35 M1, 4.35 M2 Jan 9, 2025
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue Jan 9, 2025
@jjohnstn
Support unicode characters in markdown comments
9f1c2b2 
- convert unicode chars in CoreMarkdownAccessImpl.removeDocLineIntros()
- add new test to MarkdownCommentTests
- fixes eclipse-jdt#1787
akurtakov pushed a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue Jan 22, 2025
@jjohnstn @akurtakov
Support unicode characters in markdown comments
b90bdc8 
- convert unicode chars in CoreMarkdownAccessImpl.removeDocLineIntros()
- add new test to MarkdownCommentTests
- fixes eclipse-jdt#1787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjohnstn jjohnstn

Labels
bug Something isn't working
Projects
None yet
Milestone
4.35 M2
Development

Successfully merging a pull request may close this issue.

Support unicode characters in markdown comments jjohnstn/eclipse.jdt.ui-1
2 participants
@jjohnstn @jarthana