Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire JavaFXTest which requires Java 8 #3316

Closed
wants to merge 1 commit into from

Conversation

vogella
Copy link

@vogella vogella commented Nov 4, 2024

JDT has dropped support for Java 8 in its recent release. Hence this test is or will become soon obsolete and should be removed.

Currently this test fails in a local build, requesting me to configure my toolchain.xml (which is not described in the Contributor documentation.

JDT has dropped support for Java 8 in its recent release. Hence this
test is or will become soon obsolete and should be removed.
@eclipse-ls-bot
Copy link

Can one of the admins verify this patch?

@snjeza
Copy link
Contributor

snjeza commented Nov 5, 2024

JDT has dropped support for Java 8 in its recent release. Hence this test is or will become soon obsolete and should be removed.

Could you show a JDT issue?

Currently this test fails in a local build, requesting me to configure my toolchain.xml

It shouldn't happen. See

Assume.assumeThat("JavaSE-1.8 VM is not found, skipping test", java8vm, IsNull.notNullValue());

Could you try to run the tests with -DDetectVMInstallationsJob.disabled=true?

@testforstephen
Copy link
Contributor

JDT has dropped support for Java 8 in its recent release.

If I remember correctly, JDT has dropped support for Java 7 and earlier, but Java 8 is still supported. See eclipse-jdt/eclipse.jdt.core#2551

@vogella
Copy link
Author

vogella commented Nov 5, 2024

@testforstephen ah, that is true, sorry for my misunderstanding, closing this one as wont fix.

@vogella vogella closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants