Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java LS Project's compliance to Java 21 #3363

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Jan 16, 2025

The related PR - #3358
Steps to reproduce:

  • open the Java LS projects in Eclipse

You will get Expression type cannot be a subtype of the Pattern type at

if (methodDeclaration instanceof IMember member && member.getClassFile() != null) {

@snjeza snjeza requested a review from rgrunber January 16, 2025 17:50
@rgrunber
Copy link
Contributor

I agree those references should be updated, but why am I not seeing this in my workspace ?

@rgrunber rgrunber added this to the End January 2025 milestone Jan 16, 2025
@snjeza
Copy link
Contributor Author

snjeza commented Jan 16, 2025

I agree those references should be updated, but why am I not seeing this in my workspace ?

I'm not sure.

java21.mp4

@snjeza
Copy link
Contributor Author

snjeza commented Jan 16, 2025

test this please

@rgrunber
Copy link
Contributor

rgrunber commented Jan 16, 2025

Ah, I think you're rightly running into eclipse-jdt/eclipse.jdt.core#3478 . I'm running off of 2024-09 . update: ugh, I really should get at least on 2025-03 M1.

@snjeza
Copy link
Contributor Author

snjeza commented Jan 16, 2025

Ah, I think you're rightly running into eclipse-jdt/eclipse.jdt.core#3478 . I'm running off of 2024-09 .

Do you have Java 17 in your workspace?

@rgrunber
Copy link
Contributor

rgrunber commented Jan 16, 2025

I had it under the execution environment settings but my bundles listed Java 21 as their JRE :

image

Update:
@snjeza , I can confirm I see the error with I20250116-0550 but not with I20250102-1800 (M1).

@snjeza
Copy link
Contributor Author

snjeza commented Jan 16, 2025

I had it under the execution environment settings but my bundles listed Java 21 as their JRE :

Could you try to add a JRE 17?
java21

@snjeza
Copy link
Contributor Author

snjeza commented Jan 16, 2025

test this please

Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this.

@snjeza snjeza merged commit d222199 into eclipse-jdtls:master Jan 16, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants