-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Java LS Project's compliance to Java 21 #3363
Conversation
Signed-off-by: Snjezana Peco <[email protected]>
I agree those references should be updated, but why am I not seeing this in my workspace ? |
I'm not sure. java21.mp4 |
test this please |
Ah, I think you're rightly running into eclipse-jdt/eclipse.jdt.core#3478 . I'm running off of 2024-09 . update: ugh, I really should get at least on 2025-03 M1. |
Do you have Java 17 in your workspace? |
I had it under the execution environment settings but my bundles listed Java 21 as their JRE : Update: |
test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for catching this.
The related PR - #3358
Steps to reproduce:
You will get
Expression type cannot be a subtype of the Pattern type
ateclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/NavigateToDeclarationHandler.java
Line 96 in 2102508