-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CryptoTests SunMSCAPI failing on Windows due to Access is denied #16710
Comments
@AdamBrousseau @vsebe |
It seems CryptoTests is a new test just added. |
@llxia there are also problems running these tests at Adoptium. |
@sophia-guo could you please take a look? Thanks |
Recently added test, see adoptium/aqa-tests#4319 |
Afaik, the |
I expect there are Windows machine requirements / permissions required to use SunMSCAPI. I believe there are other issues created about this for other related failures we have seen in the past. For example #12083 |
There are other tests excluded that would fail with the same "Access is denied" problem. java/security/KeyPairGenerator/FinalizeHalf.java #12807 windows-all |
Adoptium issue adoptium/aqa-tests#4336 |
The
|
|
The Adopt issue was resolved by fixes to the tests. Seems odd we are still seeing problems. |
Where were the fixes made, at OpenJDK or in an Adopt mirror? |
For the record, the tests fail every night in OpenJ9 builds. I try to keep an eye out to see if they ever pass. |
I see fixes rh-openjdk/CryptoTest#36 and rh-openjdk/CryptoTest#37 It's still possible OpenJ9 machines don't have the required permissions and need to be updated to take advantage of the test fixes, considering the errors are "Access is denied". |
Does anyone from the test team know what permissions are needed? |
CryptoTests_0 grinder on /win2019x64-openj9-5 (added jenkins user to Admins): |
I have only now discovered this. There was one earlier SunMSCAPI keystores issue with permissions (may be related): In that case, after investigating upstream jtreg tests in jdk, I have found that testing some keystore "algortihms" was conditional based on permissions. (So I have done the same for keystore tests in Cryptotest). I'll take a look, if I can find something similar for SunMSCAPI KeyPairGenerators in jtreg tests in jdk. I checked our tests in GH on windows with Temurin builds (8,11,17,20). Same tests passed there:
It is also interesting that this problem did not show up in aqa-tests issue which found the other issue. |
I have found Can you please check if that test passes for you on that system? |
The RSAEncryptDecrypt test is excluded for OpenJ9, against an issue that just basically says it didn't pass. Failing jdk11 grinder running sun/security/mscapi/RSAEncryptDecrypt.java The failures are not jdk8 specific, the CryptoTest on Windows fails on all versions. https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_extended.functional_x86-32_windows_Nightly_testList_1/496 |
Btw I was looking at problem list for openjdk8-openj9, and test is not there: |
I agree, it seems like a machine configuration issue. The entire security3 suite is disabled on jdk8, which contains RSAEncryptDecrypt. |
I got one more idea. I have realized, that I can try to switch tests in github to use jdk with OpenJ9. From what setup-java action provides, So I tried those: Cryptotest passes everywhere on both distributions, including Windows. So it seems like infrastructure problem. |
CryptoTests_0 grinder (run as admin) on win2019x64-openj9-5 -
https://openj9-jenkins.osuosl.org/job/Grinder/2210/testReport/ |
PR for exclude the test on Windows: adoptium/aqa-tests#4528 |
https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_extended.functional_x86-32_windows_Nightly_testList_1/465 - win2012-x86-8
CryptoTests_0
cryptotest/tests/CipherTests.java
The text was updated successfully, but these errors were encountered: