Create an adequately sized J9Heap to store the UpcallThunk #20926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tajila Requesting your review. |
tajila
approved these changes
Jan 15, 2025
runtime/vm/UpcallThunkMem.cpp
Outdated
| @@ -27,6 +27,8 @@ | |||
|
|
|||
| extern "C" { | |||
|
|
|||
| #define ROUND_TO(granularity, number) (((UDATA)(number) + (granularity) - 1) & ~((UDATA)(granularity) - 1)) | |||
There was a problem hiding this comment.
we have a few of these, maybe we can just define one in j9.h and add a c++ version in VMHelpers. Can be done in a separate PR
There was a problem hiding this comment.
Actually, we can use OMR/Bytes.hpp::align here. Let me update the PR since PR builds haven't been launched yet.
There was a problem hiding this comment.
Updated to use OMR/Bytes.hpp::align.
Currently, the J9Heap size to store the UpcallThunk is restricted to the page size. If the thunk is greater than the page size, then the existing code ends in an infinite loop creating J9Heaps of page size. The correct sized J9Heap will never be created so the code will never progress. To resolve this issue, an adequately sized J9Heap, aligned to the page size, is created to store the UpcallThunk. Signed-off-by: Babneet Singh <[email protected]>
|
jenkins test sanity plinux jdk24 |
|
jenkins test sanity alinux64 jdk24 |
|
The failures seen in the PR builds are unrelated to these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
J9Heapsize to store theUpcallThunkis restricted tothe page size. If the thunk is greater than the page size, then the
existing code ends in an infinite loop creating
J9Heaps of page size.The correct sized
J9Heapwill never be created so the code will neverprogress.
To resolve this issue, an adequately sized
J9Heap, aligned to the pagesize, is created to store the
UpcallThunk.