Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of VM_getReferenceSlotsInClass messages for JITServer #21123

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

mpirvu
Copy link
Contributor

@mpirvu mpirvu commented Feb 12, 2025

These messages are sent by the server to inquire about the offsets of the reference slots in a j9class.
This commit implements caching at the JITServer of the information received from the client. This change reduces the number of VM_getReferenceSlotsInClass by a factor of 10.

These messages are sent by the server to inquire about the
offsets of the reference slots in a j9class.
This commit implements caching at the JITServer of the information
received from the client. This change reduces the number of
VM_getReferenceSlotsInClass by a factor of 10.

Signed-off-by: Marius Pirvu <[email protected]>
@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Feb 12, 2025
@mpirvu mpirvu requested a review from dsouzai as a code owner February 12, 2025 16:31
@mpirvu
Copy link
Contributor Author

mpirvu commented Feb 12, 2025

jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit,alinux64jit jdk21

@dsouzai dsouzai self-assigned this Feb 12, 2025
@mpirvu
Copy link
Contributor Author

mpirvu commented Feb 13, 2025

openjdk tests failed the VectorAPI tests on all platforms. This is a known issue.
plinux has failed

22:19:27  +++ j9vm.test.classloading.K64MethodTest: +++
22:19:27  command: /home/jenkins/workspace/Test_openjdk21_j9_sanity.functional_ppc64le_linux_jit_Personal_testList_0/jdkbinary/j2sdk-image/bin/java -XX:+UseJITServer -Xjit -Xgcpolicy:gencon -Xnocompressedrefs  -Xdump -Xms64m -Xmx64m -classpath /home/jenkins/workspace/Test_openjdk21_j9_sanity.functional_ppc64le_linux_jit_Personal_testList_0/aqa-tests/TKG/../../jvmtest/functional/VM_Test/VM_Test.jar:/home/jenkins/workspace/Test_openjdk21_j9_sanity.functional_ppc64le_linux_jit_Personal_testList_0/../../testDependency/lib/asm-all.jar j9vm.test.classloading.K64MethodTest 
22:19:27  
22:20:05  Cancelling nested steps due to timeout
22:20:05  Sending interrupt signal to process
22:20:14  -----------------------------------
22:20:14  J9vmTest_0_FAILED

but it looks to me that the entire sequence of tests took too much time, rather than being a true timeout

@mpirvu
Copy link
Contributor Author

mpirvu commented Feb 13, 2025

1x grinder for the plinux failure: https://openj9-jenkins.osuosl.org/job/Grinder/4102/

@mpirvu
Copy link
Contributor Author

mpirvu commented Feb 13, 2025

That grinder passed, so the so called timeout was not real. Just the tests running too slow.

@dsouzai dsouzai merged commit 52057b7 into eclipse-openj9:master Feb 13, 2025
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants