Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-tools: EmptyStackException with javadoc on record method #1575

Closed
jukzi opened this issue Jan 20, 2025 · 1 comment · Fixed by #1598
Closed

API-tools: EmptyStackException with javadoc on record method #1575

jukzi opened this issue Jan 20, 2025 · 1 comment · Fixed by #1598
Labels
api-tools bug Something isn't working

Comments

@jukzi
Copy link
Contributor

jukzi commented Jan 20, 2025

reproducer:

package org.eclipse.pde.internal.launching;
record Any()  {
	/**
	 * error
	 */
	void foo() {
	}
}
null
org.eclipse.core.resources
Error
Mon Jan 20 14:12:34 CET 2025
Problems occurred when invoking code from plug-in: "org.eclipse.core.resources".

java.util.EmptyStackException
	at java.base/java.util.Stack.peek(Stack.java:103)
	at org.eclipse.pde.api.tools.internal.builder.Validator.getItem(Validator.java:138)
	at org.eclipse.pde.api.tools.internal.builder.TagValidator.processMethodNode(TagValidator.java:317)
	at org.eclipse.pde.api.tools.internal.builder.TagValidator.validateTags(TagValidator.java:186)
	at org.eclipse.pde.api.tools.internal.builder.TagValidator.visit(TagValidator.java:118)
	at org.eclipse.jdt.core.dom.Javadoc.accept0(Javadoc.java:229)
	at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java:3312)
	at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java:3360)
	at org.eclipse.jdt.core.dom.MethodDeclaration.accept0(MethodDeclaration.java:655)
	at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java:3312)
	at org.eclipse.jdt.core.dom.ASTNode.acceptChildren(ASTNode.java:3383)
	at org.eclipse.jdt.core.dom.RecordDeclaration.accept0(RecordDeclaration.java:311)
	at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java:3312)
	at org.eclipse.jdt.core.dom.ASTNode.acceptChildren(ASTNode.java:3383)
	at org.eclipse.jdt.core.dom.CompilationUnit.accept0(CompilationUnit.java:257)
	at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java:3312)
	at org.eclipse.pde.api.tools.internal.builder.BaseApiAnalyzer.processType(BaseApiAnalyzer.java:1217)
	at org.eclipse.pde.api.tools.internal.builder.BaseApiAnalyzer.processType(BaseApiAnalyzer.java:1200)
	at org.eclipse.pde.api.tools.internal.builder.BaseApiAnalyzer.checkTagValidation(BaseApiAnalyzer.java:1138)
	at org.eclipse.pde.api.tools.internal.builder.BaseApiAnalyzer.analyzeComponent(BaseApiAnalyzer.java:295)
	at org.eclipse.pde.api.tools.internal.builder.IncrementalApiBuilder.build(IncrementalApiBuilder.java:272)
	at org.eclipse.pde.api.tools.internal.builder.IncrementalApiBuilder.build(IncrementalApiBuilder.java:238)
	at org.eclipse.pde.api.tools.internal.builder.ApiAnalysisBuilder.work(ApiAnalysisBuilder.java:452)
	at org.eclipse.pde.api.tools.internal.builder.ApiAnalysisBuilder.build(ApiAnalysisBuilder.java:383)
	at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:1077)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:47)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:296)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:352)
	at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:441)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:47)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:444)
	at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:555)
	at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:503)
	at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:585)
	at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:207)
	at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:300)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)


@ruspl-afed
Copy link
Contributor

Perhaps this is because org.eclipse.pde.api.tools.internal.builder.Validator has no idea that it needs to process org.eclipse.jdt.core.dom.RecordDeclaration as well
I have a hope to look closer soon.

ruspl-afed added a commit to ruspl-afed/eclipse.pde that referenced this issue Jan 31, 2025
laeubi pushed a commit that referenced this issue Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-tools bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants