Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve behavior if PersistenceTypeDictionary.ptd is missing #57

Closed
hg-ms opened this issue Nov 10, 2023 · 2 comments
Closed

Improve behavior if PersistenceTypeDictionary.ptd is missing #57

hg-ms opened this issue Nov 10, 2023 · 2 comments
Assignees

Comments

@hg-ms
Copy link
Contributor

hg-ms commented Nov 10, 2023

Trying to load an existing storage with a missing PersistenceTypeDictionary.ptd causes an unclear exception.
Maybe the exception could be improved or the storage initialization could handle the case that storage files already exists but the PersistenceTypeDictionary is missing.

@hg-ms
Copy link
Contributor Author

hg-ms commented Nov 10, 2023

The TypeHandlerManager gets initialized before the storage can check for missing files.
In case of no type-dictionary file the TypeHandlerManager creates a new default type dictionary.
It is not possible to distinguish between a new storage starting the first time or starting an existing storage with a missing type-dictionary file.
As improvement an info log message could give a hint that the TypeHandlerManager uses a newly created type-dictionary at startup.

@hg-ms hg-ms self-assigned this Nov 10, 2023
@hg-ms hg-ms linked a pull request Nov 10, 2023 that will close this issue
@hg-ms hg-ms removed a link to a pull request Nov 10, 2023
@hg-ms
Copy link
Contributor Author

hg-ms commented Nov 10, 2023

fixed by eclipse-serializer: eclipse-serializer/serializer#77

@hg-ms hg-ms closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant