Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AIEditorManager #14912

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eneufeld
Copy link
Contributor

What it does

fixes #14873

  • move the customizations to the parent class EditorPreviewManager
  • rename AIEditorSelectionResolver and move it to editor-preview-manager.ts

How to test

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring looks good. I have minor comments.

fixes eclipse-theia#14873

- move the customizations to the parent class EditorPreviewManager
- rename AIEditorSelectionResolver and move it to editor-preview-manager.ts
@sdirix
Copy link
Member

sdirix commented Feb 14, 2025

@tsmaeder As this touches files outside of the AI packages, do you also want to take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs merge
Development

Successfully merging this pull request may close these issues.

Remove AIEditorManager
2 participants