Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] API evolution (public and proposed) and menu declarations between 1.96 and 1.97 -wip #14897

Open
rschnekenbu opened this issue Feb 11, 2025 · 0 comments
Assignees
Labels
vscode issues related to VSCode compatibility

Comments

@rschnekenbu
Copy link
Contributor

rschnekenbu commented Feb 11, 2025

Sources

  • commit ref for tags

  • command used

    • git difftool -d 138f619..33fc5a9 -- src/vscode-dts/ on vscode repo
    • command: git submodule foreach "grep -irn enabledApiProposals --include=package.json | cut -d ':' -f 1 | xargs jq --raw-output '{filename: input_filename, enabledApiProposals: .enabledApiProposals}'" > ./vscode-builtins-enabled-proposals-1.97.0-master.txt on vscode-builtin-extensions repo, on commit 33fc5a9
    • git difftool -d 138f619..33fc5a9 -- src/vs/workbench/services/actions/common/menusExtensionPoint.ts on vscode repo

Evaluation

vscode.d.ts

  • some comments
  • DocumentDropOrPasteEditKind, DocumentDropEditProviderMetadata, DocumentDropEditProvider are now public, from vscode.proposed.documentPaste.d.ts (already partially implemented in theia, see https://github.com/eclipse-theia/theia/blob/master/packages/plugin/src/theia.proposed.documentPaste.d.ts
  • enum TerminalShellExecutionCommandLineConfidence, interface TaskStartEvent, TaskEndEvent , WebviewPanel, WebviewPanelSerializer, WebviewViewResolveContext, CustomDocument, CustomDocumentEditEvent, CustomDocumentContentChangeEvent, CustomDocumentBackup, etc are now exported
  • ShellExecution command: string | ShellQuotedString | undefined undefined has been added and same for args: Array<string | ShellQuotedString> | undefined
  • CommentingRanges have been introduced; with some changes to commentThread and CommentingRangeProvider

Proposed API evolutions

  • vscode.proposed.aiRelatedInformation.d.ts - ignored
  • vscode.proposed.chatParticipantAdditions.d.ts - ignored
  • vscode.proposed.chatParticipantPrivate.d.ts - ignored
  • vscode.proposed.chatProvider.d.ts - ignored
  • vscode.proposed.chatReadonlyPromptReference.d.ts - ignored
  • vscode.proposed.chatReferenceBinaryData.d.ts - ignored
  • vscode.proposed.documentPaste.d.ts - deleted as a public API
  • vscode.proposed.externalUriOpener.d.ts - only added 'export' keywords
  • vscode.proposed.fileComments.d.ts - deleted as became public API (CommentingRange)
  • vscode.proposed.inlineCompletionsAdditions.d.ts - fileComments.requestUUid added - not implemented in theia yet
  • vscode.proposed.inlineEdit.d.ts - added InlineEdit readonly showRange?: Range; not yet implemented in theia
  • vscode.proposed.mappedEditsProvider.d.ts - lots of @deprecated comments & MappedEditRequest changes - proposed API implemented in theia
  • vscode.proposed.notebookVariableProvider.d.ts - only added 'export' keywords
  • vscode.proposed.quickDiffProvider.d.ts - only added 'export' keywords
  • vscode.proposed.resolvers.d.ts - only added 'export' keywords
  • vscode.proposed.scmHistoryProvider.d.ts - some elements added, used by builtin git, but still ignored
  • vscode.proposed.showLocal.d.ts - removed proposal - ignored as not converted as public API
  • vscode.proposed.statusBarItemTooltip.d.ts - new proposed API - StatusBarItem.tooltip2 added
  • vscode.proposed.terminalCompletionProvider.d.ts - optional documentation property added. Proposed API stubbed with stub TerminalCompletionProvider proposed API #14719
  • vscode.proposed.terminalQuickFixProvider.d.ts - only export keyword added
  • vscode.proposed.terminalShellEnv.d.ts - new proposed API
  • vscode.proposed.terminalShellType.d.ts - new proposed API, adds TerminalState#shellType and TerminalShellType

Menu evolutions

@rschnekenbu rschnekenbu added the vscode issues related to VSCode compatibility label Feb 11, 2025
@rschnekenbu rschnekenbu self-assigned this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

1 participant