Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AID] Redesigning Semantic References for TD -> AID #52

Open
egekorkan opened this issue Oct 2, 2024 · 1 comment
Open

[AID] Redesigning Semantic References for TD -> AID #52

egekorkan opened this issue Oct 2, 2024 · 1 comment
Assignees

Comments

@egekorkan
Copy link
Member

Looking into how the semantic annotations are currently translated, we need to rethink due to the following points:

  • Semantic annotations should not be converted like key-value pairs. Currently, something like "eclass:hasQuantity": "eclass14-0:0173-1-Z4-BAJ272-003" becomes {"idShort": "unit", "valueType": "xs:string", "value": "eclass14-0:0173-1-05-AAA153-004", "modelType": "Property"}. It should be done via semanticId, like how it is done for the WoT terms.
  • IDTA prefers the usage of conceptDescriptions to store internal and even external semantic references. That means that all our semantic references need to point to a concept description in the root of the AAS. Implementing that requires rethinking since we cannot do that if we generate only the submodel.

I would propose starting with the first point already. The second one can be done after a thorough discussion.

@egekorkan egekorkan self-assigned this Oct 2, 2024
@wiresio
Copy link
Member

wiresio commented Oct 2, 2024

https://github.com/wiresio/domus-tdd-api-plugin-aid does it like this:

{
    "modelType": "Property",
    "semanticId": {
        "keys": [
            {
                "type": "GlobalReference",
                "value": "https://eclass-cdp.com/rdf/v1/eclass/hasQuantity"
            }
        ],
        "type": "ExternalReference"
    },
    "value": "eclass14-0:0173-1-Z4-BAJ267-004",
    "valueType": "xs:string",
    "idShort": "hasQuantity"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants