Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IRS][TRACE-X] 🌟🚀 Metrics Provision and Integration for IRS and Trace-X #941

Open
1 of 70 tasks
mkanal opened this issue Oct 23, 2024 · 4 comments
Open
1 of 70 tasks
Assignees
Labels
ic represents features/dependencies to the industry core irs Feature/Bug for Item Relationship Service component Prep-R25.06 trace-x Feature/Bug for Trace-x component

Comments

@mkanal
Copy link

mkanal commented Oct 23, 2024

Overview

Explain the topic in 2 sentences

Collecting and providing IRS and Trace-X performance metrics to Prometheus where it could later be imported to e.g. Grafana to have a monitoring of the products regarding performance Metrics and KPIS.

What's the benefit?

Product provides performance metric which could be shown.

What are the Risks/Dependencies ?

  • Nothing to report

Detailed explanation

The system should collect various operational metrics from IRS and Trace-X as specified, ensuring that these metrics are available through the Prometheus interface for monitoring and visualization in Grafana. These metrics should cover contract negotiation durations, twin synchronization, asset requests, and API orchestration flows, all of which are essential for the performance and reliability monitoring of the system.

Current implementation

IRS already provides metrics via Prometheus. This will be extended.
Trace-X doesn't provide metrics via Prometheus.

Proposed improvements

  • EDC Contract Negotiation (Duration)

    • Metric: Duration per notification
    • Measurement Points:
      • Start: POST /management/v2/contractnegotiations
      • End: Endpoint response with codes 200, 400, 405, etc.
    • Metric Aggregation: Duration avg, max, min, peak of responses with different response codes.
    • Prometheus Integration: Metric data exposed to Prometheus.
    • Grafana Visualization: Displayed as time series with avg, max, min, peak.
  • Sync Duration for Sync Total Amount of Twins in DTR

    • Metric: Duration in seconds per aasIdentifier
    • Measurement Points:
      • Start: /lookup-shells
      • End: 200 Requested Asset Administration Shell IDs
    • Metric Aggregation: Duration avg, max, min, peak of responses with different response codes.
    • Prometheus Integration: Metric data exposed to Prometheus.
    • Grafana Visualization: Time series chart displaying sync duration metrics.
  • EDC Asset Requesting Flow (DTR)

    • Metric: Duration in seconds for EDC flow
    • Measurement Points:
      • Start: GET catalog with filter
      • End: Response received
    • Metric Aggregation: Duration avg, max, min, peak of responses.
    • Prometheus Integration: Metric data exposed to Prometheus.
    • Grafana Visualization: Displayed as time series with avg, max, min, peak.
  • EDC Asset Requesting Flow (Asset)

    • Metric: Duration in seconds for EDC flow
    • Measurement Points:
      • Start: GET catalog with filter
      • End: POST /management/v2/transferprocesses
    • Metric Aggregation: Duration avg, max, min, peak of responses.
    • Prometheus Integration: Metric data exposed to Prometheus.
    • Grafana Visualization: Displayed as time series with avg, max, min, peak.
  • EDC Twin Requesting Flow

    • Metric: Duration in seconds for transferring assets
    • Measurement Points:
      • Start: /management/v2/transferprocesses
      • End: Transfer process response received.
    • Metric Aggregation: Duration avg, max, min, peak of responses.
    • Prometheus Integration: Metric data exposed to Prometheus.
    • Grafana Visualization: Displayed as time series with avg, max, min, peak.
  • Order API Orchestration Before Processing

    • Metric: Order processing organization duration
    • Measurement Points:
      • Start: POST /irs/orders
      • End: DTR GET /shell/descriptor/[aasIdentifier]
    • Metric Aggregation: Duration avg, max, min, peak of responses.
    • Prometheus Integration: Metric data exposed to Prometheus.
    • Grafana Visualization: Displayed as time series with avg, max, min, peak.

Feature Team

Contributor

Committer


User Story

As a team,
I want to collect and provide IRS and Trace-X metrics to Prometheus
So that they can, the team could monitor key performance indicators in Grafana.

Description:

The system should collect various operational metrics from IRS and Trace-X as specified, ensuring that these metrics are available through the Prometheus interface for monitoring and visualization in Grafana. These metrics should cover contract negotiation durations, twin synchronization, asset requests, and API orchestration flows, all of which are essential for the performance and reliability monitoring of the system.

Acceptance Critieria

  • Metrics provided over Prometheus
  • Metrics available in Grafana
  • Metrics are implemented
  • EDC Contract Negotiation (Duration)
  • EDC Asset Requesting Flow (DTR)
  • EDC Asset Requesting Flow (Asset)
  • EDC Twin Requesting Flow
  • Order API Orchestration Before Processing

Test Cases

Test Case 1

Steps

  1. Do something
  2. Click something
  3. Add something

Expected Result

  1. Expectation
  2. Expectation
  3. Expectation

Architectural Relevance

The following items are ensured (answer: yes) after this issue is implemented:

Justification: (Fill this out, if at least one of the checkboxes above cannot be ticked. Contact the Architecture Management Committee to get an approval for the justification)

Additional information

  • I am aware that my request may not be developed if no developer can be found for it. I'll try to contribute a developer (bring your own developer)
@mkanal mkanal converted this from a draft issue Oct 23, 2024
@mkanal mkanal added trace-x Feature/Bug for Trace-x component irs Feature/Bug for Item Relationship Service component Prep-R25.03 labels Oct 23, 2024
@mkanal mkanal changed the title [IRS][TRACE-X] 🌟 Metrics Provision and Integration for IRS and Trace-X [IRS][TRACE-X] 🌟🚀 Metrics Provision and Integration for IRS and Trace-X Oct 23, 2024
@mkanal mkanal added this to the 25.03 milestone Nov 5, 2024
@eckardg eckardg removed this from the 25.03 milestone Nov 6, 2024
@eckardg eckardg added the ic represents features/dependencies to the industry core label Nov 6, 2024
@stephanbcbauer
Copy link
Member

Some hints from Release Management (@ther3sa) and Tractus-X Project Lead (@stephanbcbauer)

  • Status currently in Backlog -> Since for Backlog some requirements are missing ... please update them
  • Please add missing sections from the feature template, or fill them out
  • Please add assignee (overall responsible person who drives the feature)

@mkanal mkanal self-assigned this Nov 11, 2024
@stephanbcbauer stephanbcbauer added this to the 25.03 milestone Nov 14, 2024
@mkanal
Copy link
Author

mkanal commented Jan 30, 2025

@eckardg and @JSterthues
This feature will be moved from 25.3 to 25.3.
CC: @rogocof

@mkanal mkanal moved this from Backlog to Work in progress in Release Planning Jan 30, 2025
@mkanal mkanal moved this from Work in progress to Backlog in Release Planning Jan 30, 2025
@stephanbcbauer
Copy link
Member

I deleted the milestone, since the milestone is set together in the open planning session. This means ⇾ commitment to work on the feature. THX

@stephanbcbauer stephanbcbauer removed this from the 25.03 milestone Feb 18, 2025
@stephanbcbauer
Copy link
Member

was not presented in open planning. Nobody was available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ic represents features/dependencies to the industry core irs Feature/Bug for Item Relationship Service component Prep-R25.06 trace-x Feature/Bug for Trace-x component
Projects
Status: Backlog
Development

No branches or pull requests

4 participants