You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The goal is to enhance the IRS API by allowing it to accept Asset Administration Shell (AAS) identifiers directly, alongside globalAssetIds, as keys in POST requests. This change is meant to simplify data resolution processes for the Trace-X application, reducing the need for manual lookups.
What's the benefit?
By allowing AAS identifiers as input keys, the system eliminates the need for the Trace-X application to receive AAS shell to extract globalAssetIds which is used as input param for irs. This streamlines the API interaction, improving efficiency and reducing error-prone conversions.
What are the Risks/Dependencies?
The main risk is potential ambiguity or conflicts if both globalAssetId and AAS identifiers are provided simultaneously. This can lead to issues with result resolution or misinterpretation, necessitating robust error handling.
Detailed explanation
Current implementation
The current implementation of the IRS API only accepts globalAssetId as a key in the POST /irs/orders request. It does not provide an option to pass an AAS identifier directly, which forces clients like Trace-X to resolve AAS identifiers to globalAssetIds before making the API call.
Proposed improvements
The enhancement proposes to allow the IRS API to accept both AAS identifiers and globalAssetIds as keys, with clear differentiation in how they are handled. Three options are outlined:
Option A: Add a separate identifier field alongside globalAssetId.
Option B: Combine both identifier types in a single field with a clear prefix.
Option C: Keep the current implementation but accept both key types with no distinction, though this would limit error handling capabilities.
As an IRS api user,
I want the POST /irs/orders API to accept an AAS (Asset Administration Shell) identifier as a key,
so that the Trace-X application does not need to resolve the aas identifiers to globalAssetIds for each of the requested Twins
Specification
ADR record of issue (X) defines the api parameter to be used analogous to new /irs/jobs api
The identifier is qualified inside value as prefix: ”globalAssetId: ” or ”identifier:”
Option C:
No changes in api - key id accepted in key.
disadvantage: no specific error handling because the system does not know the type of the key so it is not possible to say whether there is no result for the globalAssetId or the identifier.
The impact on the overall system architecture has been assessed. The Feature does not require changes to the architecture or any existing standard? Please have a look here on the overarching architecture
Potential risks or conflicts with existing architecture has been assessed
Justification:(Fill this out, if at least one of the checkboxes above cannot be ticked. Contact the Architecture Management Committee to get an approval for the justification)
Additional information
I am aware that my request may not be developed if no developer can be found for it. I'll try to contribute a developer (bring your own developer)
The text was updated successfully, but these errors were encountered:
mkanal
changed the title
[TRACE-X] 🌟 API Change POST /irs/order providing aas identifier as key
[TRACE-X] 🌟🚀 API Change POST /irs/order providing aas identifier as key
Oct 23, 2024
mkanal
changed the title
[TRACE-X] 🌟🚀 API Change POST /irs/order providing aas identifier as key
[IRS] 🌟🚀 API Change POST /irs/order providing aas identifier as key
Oct 28, 2024
mkanal
added
irs
Feature/Bug for Item Relationship Service component
and removed
trace-x
Feature/Bug for Trace-x component
labels
Oct 28, 2024
Overview
Explain the topic in 2 sentences
The goal is to enhance the IRS API by allowing it to accept Asset Administration Shell (AAS) identifiers directly, alongside globalAssetIds, as keys in POST requests. This change is meant to simplify data resolution processes for the Trace-X application, reducing the need for manual lookups.
What's the benefit?
By allowing AAS identifiers as input keys, the system eliminates the need for the Trace-X application to receive AAS shell to extract globalAssetIds which is used as input param for irs. This streamlines the API interaction, improving efficiency and reducing error-prone conversions.
What are the Risks/Dependencies?
The main risk is potential ambiguity or conflicts if both globalAssetId and AAS identifiers are provided simultaneously. This can lead to issues with result resolution or misinterpretation, necessitating robust error handling.
Detailed explanation
Current implementation
The current implementation of the IRS API only accepts globalAssetId as a key in the POST /irs/orders request. It does not provide an option to pass an AAS identifier directly, which forces clients like Trace-X to resolve AAS identifiers to globalAssetIds before making the API call.
Proposed improvements
The enhancement proposes to allow the IRS API to accept both AAS identifiers and globalAssetIds as keys, with clear differentiation in how they are handled. Three options are outlined:
Feature Team
Contributor
Committer
User Story
As an IRS api user,
I want the POST /irs/orders API to accept an AAS (Asset Administration Shell) identifier as a key,
so that the Trace-X application does not need to resolve the aas identifiers to globalAssetIds for each of the requested Twins
Specification
Option A:
The identifier is qualified by key. globalAssetId as globalAssetId and identifier as identifier
Option B:
The identifier is qualified inside value as prefix: ”globalAssetId: ” or ”identifier:”
Option C:
No changes in api - key id accepted in key.
disadvantage: no specific error handling because the system does not know the type of the key so it is not possible to say whether there is no result for the globalAssetId or the identifier.
GET /irs/job/{id} extend
Acceptance Criterias
Test Cases
Test Case 1
Steps
Expected Result
Architectural Relevance
The following items are ensured (answer: yes) after this issue is implemented:
Justification: (Fill this out, if at least one of the checkboxes above cannot be ticked. Contact the Architecture Management Committee to get an approval for the justification)
Additional information
The text was updated successfully, but these errors were encountered: