Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IATP Mock from umbrella #204

Open
mgarciaLKS opened this issue Jan 28, 2025 · 1 comment
Open

Remove IATP Mock from umbrella #204

mgarciaLKS opened this issue Jan 28, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@mgarciaLKS
Copy link
Contributor

mgarciaLKS commented Jan 28, 2025

Description

Now that the DIM WALLET STUB has been implemented and is the recommended solution, the IATP mock is no longer necessary.

Additionally, the IATP mock increases the size of the umbrella application and consumes unnecessary resources, as it includes its own set of tests.

There have been instances where PRs trigger runtime errors, causing tests to fail. Removing the IATP mock will help streamline the codebase, reduce resource usage, and prevent these runtime issues.

Proposed Action

Remove the IATP mock implementation and its associated tests.

@mgarciaLKS mgarciaLKS added the bug Something isn't working label Jan 28, 2025
@mgarciaLKS mgarciaLKS self-assigned this Jan 28, 2025
@kss682
Copy link
Contributor

kss682 commented Jan 28, 2025

Eg: PR #198 fails due to IATP mock test.

@mgarciaLKS mgarciaLKS moved this from Todo to In Progress in Umbrella Helm Chart Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

No branches or pull requests

2 participants