From 4e79b89536631fc1aaf88f6189b0591c7e8ed435 Mon Sep 17 00:00:00 2001
From: psolomin
Date: Fri, 28 Apr 2023 14:50:52 +0100
Subject: [PATCH] Add notes
---
.../src/main/java/io/vertx/pgclient/PgConnection.java | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/vertx-pg-client/src/main/java/io/vertx/pgclient/PgConnection.java b/vertx-pg-client/src/main/java/io/vertx/pgclient/PgConnection.java
index 5e765550b..e00ed44c2 100644
--- a/vertx-pg-client/src/main/java/io/vertx/pgclient/PgConnection.java
+++ b/vertx-pg-client/src/main/java/io/vertx/pgclient/PgConnection.java
@@ -130,6 +130,15 @@ static Future connect(Vertx vertx, String connectionUri) {
*
* @param sql COPY command (example {@code COPY my_table TO STDOUT (FORMAT csv)})
* @return async result of bytes container data will be written to
+ *
+ * - vertx.core.stream - https://vertx.io/docs/apidocs/io/vertx/core/streams/ReadStream.html
+ * - future of read stream.
+ * - when we do query operation
+ * - we should not use query result builder
+ * - what about SELECT 1;SELECT 1 or COPY ....;COPY ... ?
+ * - we need a new interface Future>
+ * - https://vertx.io/docs/apidocs/io/vertx/core/streams/ReadStream.html
+ * - PgSocketConnection - we will apply backpressure in SocketInternal
*/
Future> copyToBytes(String sql);