Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ConfigProperty applicable to a TYPE or a METHOD? #58

Open
jeanouii opened this issue Mar 8, 2018 · 3 comments
Open

@ConfigProperty applicable to a TYPE or a METHOD? #58

jeanouii opened this issue Mar 8, 2018 · 3 comments

Comments

@jeanouii
Copy link
Contributor

jeanouii commented Mar 8, 2018

The @ConfigProperty has a target like

@Target({METHOD, FIELD, PARAMETER, TYPE})

Do we currently support METHOD and TYPE?
Looks like in most cases, it's for fields.

For version, I would only keep FIELD and PARAMETER that we can easily support

Happy to push a PR if we are ok.

@smoyer64
Copy link

I would say that CONSTRUCTOR and METHOD are more appropriate than TYPE as those two targets would potentially be used by those in a CDI environment.

@struberg
Copy link
Contributor

Yes, I'm not sure myself why it's TYPE, but TYPE is really cool as it allows us to apply it to interfaces!

In Geronimo-config we used this to implement interface-style config a la Apache DeltaSpike.
See #12

@struberg
Copy link
Contributor

We should probably rename it to something else? @Configured for example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants