Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getKeyByXXX is not awared of body parameters #242

Open
QzCurious opened this issue Nov 23, 2022 · 5 comments
Open

getKeyByXXX is not awared of body parameters #242

QzCurious opened this issue Nov 23, 2022 · 5 comments
Labels
bug Something isn't working pinned issues that should not be closed by bot v11 target

Comments

@QzCurious
Copy link
Contributor

Although only get method is documented, I wish to have getKeyByXXX take other http method into account.

Here a simple proposal make from zodios/react
image

Maybe it would be solved by v11 as AxiosRequestConfig and zodios request payload will be combined together.

@ecyrbe
Copy link
Owner

ecyrbe commented Nov 23, 2022

hello,

There are no keys for mutations. see react-query documentation: https://tanstack.com/query/v4/docs/guides/mutations

If you meant to use body for immutable queries using post, then yes this will be fixed with v11.

@QzCurious
Copy link
Contributor Author

If you meant to use body for immutable queries using post, then yes this will be fixed with v11.

Oh yes, it is about the immutable query. Iwas stupid at that time.

@stale
Copy link

stale bot commented Dec 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 24, 2022
@stale stale bot closed this as completed Dec 31, 2022
@ecyrbe ecyrbe reopened this Dec 31, 2022
@stale stale bot removed the wontfix This will not be worked on label Dec 31, 2022
@ecyrbe ecyrbe added the bug Something isn't working label Jan 16, 2023
@stale
Copy link

stale bot commented Feb 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 16, 2023
@stale stale bot closed this as completed Feb 23, 2023
@ecyrbe ecyrbe reopened this Feb 23, 2023
@stale stale bot removed the wontfix This will not be worked on label Feb 23, 2023
@stale
Copy link

stale bot commented Mar 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 25, 2023
@ecyrbe ecyrbe added the pinned issues that should not be closed by bot label Mar 25, 2023
@stale stale bot removed the wontfix This will not be worked on label Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pinned issues that should not be closed by bot v11 target
Projects
None yet
Development

No branches or pull requests

2 participants