Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages/kata-runtime: allow arbitrary CDI annotations #1216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Feb 7, 2025

As discussed via Teams, there is no sense in checking CDI annotations if the agent doesn't care about them anyway. This allows arbitrary CDI annotations in the policy.

@msanft msanft added the no changelog PRs not listed in the release notes label Feb 7, 2025
@msanft msanft added this to the v1.5.0 milestone Feb 7, 2025
@msanft msanft requested a review from burgerdev February 7, 2025 10:51
@msanft msanft requested a review from katexochen as a code owner February 7, 2025 10:51
@burgerdev
Copy link
Contributor

There is a runtime function constrainGRPCSpec - if we removed annotations there we would be sure that they are not used by the agent and could keep the current annotation verification.

As discussed via Teams, there is no sense in checking CDI annotations if the agent doesn't care about them anyway. This allows arbitrary CDI annotations in the policy.
@msanft msanft force-pushed the msanft/kata-runtime/arbitrary-cdi branch from 269828e to 86b1a59 Compare February 7, 2025 12:14
@msanft msanft changed the title packages/kata-runtime: alow arbitrary CDI annotations packages/kata-runtime: allow arbitrary CDI annotations Feb 7, 2025
@msanft msanft force-pushed the msanft/kata-runtime/arbitrary-cdi branch 2 times, most recently from 9cfe33c to 86b1a59 Compare February 7, 2025 15:50
@msanft
Copy link
Contributor Author

msanft commented Feb 7, 2025

GPU E2E Test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants