Hi @bernard-yip. thanks for your contribution.

before starting the review of the PR I'd suggest to add something to make sure jq is installed. I'm using a linux server to perform the updates. I would say something like:

1. check if jq is installed
2. if not install it through apt
3. check if now it's installed

Hey @edoardottt , definitely!

What distribution is the Linux server (Ubuntu, RHEL, CentOS) and would you prefer the snippet to be in the check-missing-templates.sh or the update.sh script?

Suggested snippet:

jq --help >/dev/null || sudo apt update -y && sudo apt install -y jq

I'm not sure this works correctly... why >/dev/null ?

If jq is installed apt is called anyway.. am i wrong? @bernard-yip

Hi @edoardottt /dev/null redirects the output so that we don't see it since we have no use for it. The command above only performs the apt update and apt install if jq is not installed. If jq is installed, it will skip the update and install.

Hi @edoardottt /dev/null redirects the output so that we don't see it since we have no use for it. The command above only performs the apt update and apt install if jq is not installed. If jq is installed, it will skip the update and install.

On my machine it calls apt update and install even if jq is already installed:

> jq --help >/dev/null || sudo apt update -y && sudo apt install -y jq
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
jq is already the newest version (1.7.1-3build1).
0 upgraded, 0 newly installed, 0 to remove and 2 not upgraded.

Urgh my bad, I forgot the parenthesis

jq --help >/dev/null || (sudo apt update -y && sudo apt install -y jq)

Hi @bernard-yip ! Sorry for the late response, I've not been very active on GitHub lately.

I've created a new branch for development called devel. I've switched the base branch from main to devel since I would like to have a dry-run before committing these changes in production server.

I don't see any red flag in the code :) If you don't have any addition/deletion to commit, I'll merge this is devel branch and produce some results to see the output and how it behaves.

One more thing: can you confirm that this PR doesn't add the description in the markdown format? Just to be on the same page, since #8 will require new additions.

edoardo

Feel free to merge! You will have to add the check if jq is installed in your update script and it will be good to go.

Yes, the PR doesn't add the markdown format. Only the JSON part.