Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Enabling distributed tracing for LMS workers #174

Closed
2 tasks
robrap opened this issue Jan 31, 2023 · 5 comments
Closed
2 tasks

[Observability] Enabling distributed tracing for LMS workers #174

robrap opened this issue Jan 31, 2023 · 5 comments
Labels
escalate-to-psre Create a PSRE ticket for this issue

Comments

@robrap
Copy link
Contributor

robrap commented Jan 31, 2023

A.C.

  • Enable distributed tracing for the New Relic app (e.g. LMS workers).
  • It would be nice to see where else this should be enabled.

Two options for configuring:

  1. Enable server-side config, which means turn on configuration in the New Relic UI, or
  2. Add to a New Relic configuration file, but there is only one template in edx-configuration.

Downsides of option 1:
a. defaults that I think are different from what we have now, so we’d need to look that up and set things appropriately to not start getting different behavior, and
b. it’s not config as code, and
c. there are other configurations I’d like to add later, but they are only available via option 2.

Downsides of option 2:
a. We don’t have a way to provide different config for different apps.

We are actively deprecating edx-configuration. What will be the ultimate solution for files like this New Relic configuration? Can we fast track this type of work so we have an option here?

@robrap robrap added the backlog To be put on a team's backlog or wishlist label Jan 31, 2023
@robrap
Copy link
Contributor Author

robrap commented Jan 31, 2023

FYI: @jmbowman @adzuci

@adzuci adzuci added the escalate-to-psre Create a PSRE ticket for this issue label Jan 31, 2023
@adzuci
Copy link

adzuci commented Jan 31, 2023

If we do 1 now can we do 2 later? Also, could you link me to the place in configuration where this is set currently?

@adzuci
Copy link

adzuci commented Jan 31, 2023

I tried to add the escalate-to-psre label to push a request to SRE which could be edited to add ACs to ask us to provide guidance on where to add code for option 2. If that GHA workflow still doesn't work could you add a ticket directly to PSRE and tag @nadeemshahzad and I on it so we can slate it for our next sprint?

@robrap
Copy link
Contributor Author

robrap commented Jan 31, 2023

@adzuci:

@robrap robrap removed the backlog To be put on a team's backlog or wishlist label Apr 20, 2023
@jristau1984
Copy link

I believe this can now be closed.

@robrap robrap closed this as completed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
escalate-to-psre Create a PSRE ticket for this issue
Projects
Archived in project
Development

No branches or pull requests

3 participants