Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD] Investigate Feature Flag tracking, which is included in RUM cost #635

Open
jristau1984 opened this issue May 13, 2024 · 8 comments
Open
Assignees

Comments

@jristau1984
Copy link

jristau1984 commented May 13, 2024

@jristau1984 jristau1984 converted this from a draft issue May 13, 2024
@robrap
Copy link
Contributor

robrap commented May 18, 2024

I put this under the new Future epic. Let me know if that doesn't feel right.

@jristau1984 jristau1984 removed this from Arch-BOM May 31, 2024
@huniafatima-arbi huniafatima-arbi moved this from Todo to In Progress in Arbi-BOM Dec 26, 2024
@huniafatima-arbi huniafatima-arbi self-assigned this Dec 26, 2024
@huniafatima-arbi huniafatima-arbi moved this from In Progress to Author Team Review in Arbi-BOM Dec 31, 2024
@huniafatima-arbi
Copy link
Member

I have created a draft documenting the pros, cons and the effort cost against this ticket.
Link to the draft
@iamsobanjaved @UsamaSadiq Please give it a review.

@robrap
Copy link
Contributor

robrap commented Jan 6, 2025

Hello @huniafatima-arbi. Thanks. I imagine that we'd need the custom feature flag management: https://docs.datadoghq.com/real_user_monitoring/guide/setup-feature-flag-data-collection/?tab=browser&site=us#custom-feature-flag-management. I wonder if your discovery could next go for a timeboxed proof-of-concept, where you try to get this going locally. Then you could determine any challenges in making this pluggable. You could make it work against a test app in Datadog.

If everything works, later, your new code could also be behind a feature flag, and you could enable this in different places and see if it really has a noticeable performance impact.

@robrap
Copy link
Contributor

robrap commented Jan 23, 2025

@huniafatima-arbi: Sorry - I've been out all week.

  • I didn't realize this was a RUM feature of DD, so I imagine it would just deal with feature flags in the MFEs.
    • I don't know enough about the DD feature or how we handle flags in our MFEs to provide guidance.
    • I also didn't create the ticket, so I can't really speak to scope. But, if you are only dealing with MFEs, it seems like backend flags wouldn't count unless they were sent to the MFE? Again, I'm not sure.
  • My initial guidance was more general about trying to dive into PoC mode, in addition to the documentation, so you could have more clarity on how this works and if we want it, etc.

@dianakhuang
Copy link
Member

@jristau1984 the information on the edxapp feature toggles: https://2u-internal.atlassian.net/wiki/spaces/AT/pages/edit-v2/1622868010

@huniafatima-arbi
Copy link
Member

https://2u-internal.atlassian.net/wiki/spaces/AT/pages/edit-v2/1622868010

Hi @dianakhuang I believe you have attached the link to our standup notes rather than the DataDog features document. Can you please provide link to that one?
Thank you

@dianakhuang
Copy link
Member

🤦 @huniafatima-arbi this should be the correct link: https://2u-internal.atlassian.net/wiki/spaces/AT/pages/16384615/Toggles+State+Reports it's not Datadog toggles tracking, but it is a report on the current state of our toggles.

@robrap
Copy link
Contributor

robrap commented Feb 19, 2025

  1. Note that the DD feature seems to be for RUM (frontends), and the Toggle Stage Report is mostly for backends.
  2. You should also be aware of this in-progress OEP: [WIP] Add an OEP defining the use of OpenFeature for feature toggles openedx/open-edx-proposals#663.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Author Team Review
Development

No branches or pull requests

4 participants