Minor DD monitor terraform enhancements

[robrap]

Note: I was just going to make a PR, but I could find some of this.

Here is an example arch-bom monitor created by the terraform: https://app.datadoghq.com/monitors/146368084?view=spans.

Minor fixes:

1. Introduce enough \ns so that:

• Before:

  • {{#is_warning}} {{override_priority 'P5'}} {{/is_warning}}Low apdex on prod edx-edxapp-lms. Apdex and Error Sustained Safety Net Alert

• After:

  • {{#is_warning}} {{override_priority 'P5'}} {{/is_warning}}

    Low apdex on prod edx-edxapp-lms. Apdex and Error Sustained Safety Net Alert

2. Nit: Consider putting the is_warning at the bottom, or lower down.
3. Remove the word monitor from the end of the monitor title. It just makes for a longer title, and doesn't add any value.

Note: For arch-bom, we won't pick up these fixes unless we intentionally make changes and reapply. It may not be worth it.

[robrap]

@alangsto: I realized that I have no idea how this terraform module works: https://github.com/edx/terraform/tree/245309540571553cf3000086faa748c49cef11fe/plans/edx/datadog/apm-common-service-monitors. I can't actually find where any of these changes would be done. Can you point me in the right direction?

[alangsto]

@robrap sorry for the later reply, I just got back from two weeks of PTO. This repo is where you could make changes to the monitor logic: https://github.com/edx/tf-module-datadog-apm-common-service-monitors/blob/main/main.tf.

[robrap]

@alangsto: I hope you had a great time off. Thanks for the link. My brain was on a one-track mission to find this code in the terraform repo, and was missing the source links https://github.com/edx/terraform/blob/d405a0071572fd907ddb78db4bea17a0ad6071b7/plans/edx/datadog/apm-common-service-monitors/common-service-monitors.tf#L2. Thanks.