You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This probably should be two separate tasks (kafka consumers and celery workers), but adding one to start to capture the ideas.
Implementation thoughts:
In Datadog, I'm not sure if the Python version can be seen manually. This might need to be asked in a DD support ticket.
These changes may highlight where DatadogBackend is missing in other services, and thus they might be missing all custom span tags. So this dashboard might serve as a useful verification that all services are set up correctly.
Of course we'd need to expand the operation_name on this dashboard to include celery and kafka consumer related operations.
Take the part of DeploymentMonitoringMiddleware that actually sets the custom attributes, and make it into a utility method that could be used from outside the middleware as well
In event-bus-kafka, we could add a call to this new method here. Reminder: add an edx-django-utils minimum constraint in base.in to ensure it gets published as part of the package.
The Celery change is a little trickier, only because we don't have a mechanism set up to plug in to all services yet (although this is very close).
If the plugin were defined in edx-django-utils, it would get added to all services (once the new plugin endpoint were defined and added to each service), because this library is already installed in each service.
The trouble with doing this in edx-django-utils is that it probably won't work for New Relic. That said, the feature benefits the entire community for upgrades, so hopefully this would be acceptable.
The alternative would be to create a 2u-django-utils repo that privately gets deployed to all our services. This is a nice-to-have capability in the long run, but would take additional work, so we'd need to consider if it is worth it.
The text was updated successfully, but these errors were encountered:
This probably should be two separate tasks (kafka consumers and celery workers), but adding one to start to capture the ideas.
Implementation thoughts:
The text was updated successfully, but these errors were encountered: