From e84a72d76a01df9b9437b562148c12b2b8754b0d Mon Sep 17 00:00:00 2001
From: "omer.habib" <omer.habib26@gmail.com>
Date: Tue, 4 Feb 2025 17:00:58 +0500
Subject: [PATCH] fix: Address PR comments-2

---
 .../presentation/comments/DiscussionCommentsFragment.kt         | 2 +-
 .../presentation/threads/DiscussionThreadsFragment.kt           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/discussion/src/main/java/org/openedx/discussion/presentation/comments/DiscussionCommentsFragment.kt b/discussion/src/main/java/org/openedx/discussion/presentation/comments/DiscussionCommentsFragment.kt
index da5ca6cbc..e6337b84b 100644
--- a/discussion/src/main/java/org/openedx/discussion/presentation/comments/DiscussionCommentsFragment.kt
+++ b/discussion/src/main/java/org/openedx/discussion/presentation/comments/DiscussionCommentsFragment.kt
@@ -181,7 +181,7 @@ class DiscussionCommentsFragment : Fragment() {
                 var fromNotificationNavigation by rememberSaveable {
                     mutableStateOf(viewModel.responseId.isNotEmpty() && viewModel.commentId.isNotEmpty())
                 }
-                LaunchedEffect(uiState is DiscussionCommentsUIState.Success) {
+                LaunchedEffect(uiState) {
                     if (uiState is DiscussionCommentsUIState.Success && fromNotificationNavigation) {
                         val commentsData =
                             (uiState as DiscussionCommentsUIState.Success).commentsData
diff --git a/discussion/src/main/java/org/openedx/discussion/presentation/threads/DiscussionThreadsFragment.kt b/discussion/src/main/java/org/openedx/discussion/presentation/threads/DiscussionThreadsFragment.kt
index 2cb52fa1f..c698d1808 100644
--- a/discussion/src/main/java/org/openedx/discussion/presentation/threads/DiscussionThreadsFragment.kt
+++ b/discussion/src/main/java/org/openedx/discussion/presentation/threads/DiscussionThreadsFragment.kt
@@ -185,7 +185,7 @@ class DiscussionThreadsFragment : Fragment() {
                     mutableStateOf(threadId.isNotEmpty())
                 }
 
-                LaunchedEffect(uiState is DiscussionThreadsUIState.Threads) {
+                LaunchedEffect(uiState) {
                     if (uiState is DiscussionThreadsUIState.Threads && fromNotificationNavigation) {
                         val data = (uiState as DiscussionThreadsUIState.Threads).data
                         data.find { it.id == threadId }?.let {