Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: In App Purchases(IAP) Improvements #17

Merged
merged 8 commits into from
Jul 25, 2024
Merged

fix: In App Purchases(IAP) Improvements #17

merged 8 commits into from
Jul 25, 2024

Conversation

farhan-arshad-dev
Copy link
Member

Description

  • Add value prop screen event.
  • Remove value_prop_enabled check for IAP.
  • Put restore button behind the IAP enable config.
  • Make IAP error dialog Non-Cancellable.
  • Hide the upgrade button for collapsed toolbar in course dashboard.
  • Improve IAP full-screen dialog UI.
Old Improved
Screenshot_20240724_184037 Screenshot_20240724_194230

@farhan-arshad-dev farhan-arshad-dev requested review from k1rill, HamzaIsrar12 and omerhabib26 and removed request for k1rill, HamzaIsrar12 and omerhabib26 July 24, 2024 14:47
HamzaIsrar12
HamzaIsrar12 requested changes Jul 24, 2024
View reviewed changes
Copy link

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

core/src/main/java/org/openedx/core/presentation/IAPAnalytics.kt Outdated Show resolved Hide resolved
core/src/main/java/org/openedx/core/presentation/iap/IAPViewModel.kt Outdated Show resolved Hide resolved
core/src/main/java/org/openedx/core/ui/IAPUI.kt Show resolved Hide resolved
core/src/main/java/org/openedx/core/presentation/dialog/IAPDialogFragment.kt Show resolved Hide resolved
core/src/main/java/org/openedx/core/presentation/dialog/IAPDialogFragment.kt Show resolved Hide resolved
@farhan-arshad-dev
Copy link
Member Author

@HamzaIsrar12 PR is ready for another pass.

@farhan-arshad-dev farhan-arshad-dev merged commit ae34c4c into edx:2U/develop Jul 25, 2024
4 checks passed
@farhan-arshad-dev farhan-arshad-dev deleted the farhan_ar/iap_fixes branch July 25, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamzaIsrar12 HamzaIsrar12 HamzaIsrar12 approved these changes

@k1rill k1rill Awaiting requested review from k1rill

@omerhabib26 omerhabib26 Awaiting requested review from omerhabib26

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farhan-arshad-dev @HamzaIsrar12