Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some work to get the Skills MFE caught up on some dependency upgrades.
Covered in this PR
Form.Autosuggest
andChip
componentsredux
andreact-redux
packages — they are not being used^
to the latest minor versionenv.config.js
to.gitignore
as well as provides example config file to help set up AlgoliaForm.Autosuggest
The Form.Autosuggest received mostly updates in the way it's implemented in the code. However, most of these changes were made to facilitate some a11y issues that required extra work from the consumer to get the UI to be accessible. It should be accessible out-of-the-box now.
To check it out for yourself:
npm ci && npm start
localhost:1992
Chip
The Chip has received some UI updates that seem fine to me. The only downside is they look a little more "clickable" now than they did before. The Chip component can be clickable, but the way we are implementing them here is simply to display information.