feat: Update to scroll behavior and UX tweaks #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rijuma
commented
Dec 19, 2024
Comment on lines
-40
to
-75
| const chatboxContainerRef = useRef(null); | ||
|
|
||
| // this use effect is intended to scroll to the bottom of the chat window, in the case | ||
| // that a message is larger than the chat window height. | ||
| useEffect(() => { | ||
| const messageContainer = chatboxContainerRef.current; | ||
|
|
||
| if (messageContainer) { | ||
| const { scrollHeight, clientHeight } = messageContainer; | ||
| const maxScrollTop = scrollHeight - clientHeight; | ||
| const duration = 200; | ||
|
|
||
| if (maxScrollTop > 0) { | ||
| const startTime = Date.now(); | ||
| const endTime = startTime + duration; | ||
|
|
||
| const scroll = () => { | ||
| const currentTime = Date.now(); | ||
| const timeFraction = (currentTime - startTime) / duration; | ||
| const scrollTop = maxScrollTop * timeFraction; | ||
|
|
||
| messageContainer.scrollTo({ | ||
| top: scrollTop, | ||
| behavior: 'smooth', | ||
| }); | ||
|
|
||
| if (currentTime < endTime) { | ||
| requestAnimationFrame(scroll); | ||
| } | ||
| }; | ||
|
|
||
| requestAnimationFrame(scroll); | ||
| } | ||
| } | ||
| }, [messageList, isOpen, apiError]); | ||
|
|
There was a problem hiding this comment.
The scrolling behavior was moved to the ChatBox component directly refactored to be much simpler.
rijuma
force-pushed
the
rijuma/xpert-scroll-behavior-update
branch
from
a3f8b00 to
c2b0504
Compare
MichaelRoytman
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: COSMO-597🔒
Description
This PR changes the way the chat scroll behaves. Its default behavior to have a smooth scroll down whenever a new message appears causes a weird experience on opening with an existing chat history to smooth scroll all messages down each time it opens. These changes makes the first render to scroll instantly to the last message on open and then uses smooth scrolling on each new message.
Additionally, it tweaks the UI to make it closer to the original design and added some extra tweaks.
#Screenshots
Old UI
New UI
Note
Notice some UI improvements like using shadows at the top and bottom of the chat scroll list, the shadows now are cast over the messages rather than clipping behind them and updated some sizes and paddings to make it nicer to the eye.