IMPORT intermittently generates incorrect multi-level packages when defined from a String

[julianpeeters]

Defining in IMPORT with a Symbol seems to have solved my issue, but I thought I should report issue I had when generating imports from Strings.

For example "org.apache.avro.Schema" variously becomes "org.Schema", or "org.apache.org.apache.avro.Schema", etc, until I predefine the Symbol with RootClass.newClass("org.apache.avro.Schema").

I tried to make a MRE, but it seems that the project needs to be large and slow for this issue to arrise(?).

[julianpeeters]

Tracked the bug to here (id.symbol.fullName is already corrupted), but not further because I don't follow how symbols are generated from the String arguments of IMPORT.

treehugger/library/src/main/scala/treehugger/TreePrinters.scala

Line 31 in d196638

case id: Ident if id.symbol != NoSymbol => id.symbol.fullName

[eed3si9n]

I wonder if there's some race condition around

treehugger/library/src/main/scala/treehugger/Definitions.scala

Lines 658 to 667 in d196638

	private def getModuleOrClass(path: Name, len: Int): Symbol =
	symbolCache.getOrElseUpdate(path, {
	val point = path lastPos('.', len - 1)
	val owner =
	if (point > 0) getModuleOrClass(path.toTermName, point).moduleClass
	else RootClass
	val name = path subName (point + 1, len)
	if (path.isTypeName) owner.newClass(name.toTypeName)
	else owner.newModule(name.toTermName)
	})

[er1c]

This is definitely a mind-phrack while debugging, confirmed the Symbol references fixes the problem.

[franzhcs]

Just quickly to mention that I have hit this problem today (on 0.4.3).