Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volumes for nginx container can be mounted from the environment file #27

Open
kneerunjun opened this issue Jan 8, 2022 · 0 comments
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kneerunjun
Copy link
Contributor

services:
  nginx:
    build: ./nginx
    ports:
      - "80:80"
    volumes: 
      # for local development the volume mapping changes
      # - "/home/niranjan/repos/eensymachines.in/luminapi/nginx/luminapp:/var/www/luminapp"
      - "/root/repos/eensymachines.in/luminapi/nginx/luminapp:/var/www/luminapp"

Its counter productive to change the volume definition everytime. need to pick this from environment file

@kneerunjun kneerunjun added the enhancement New feature or request label Jan 8, 2022
@kneerunjun kneerunjun added this to the v1.0.0 milestone Jan 8, 2022
@kneerunjun kneerunjun self-assigned this Jan 8, 2022
kneerunjun added a commit that referenced this issue Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant