Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor device-schedules.html view and the controller #32

Open
kneerunjun opened this issue Feb 11, 2022 · 6 comments
Open

refactor device-schedules.html view and the controller #32

kneerunjun opened this issue Feb 11, 2022 · 6 comments
Assignees
@kneerunjun
Labels
enhancement New feature or request

Comments

@kneerunjun
Copy link
Contributor

this is getting spaghetti and needs refactor and re-design
@kneerunjun kneerunjun added the enhancement New feature or request label Feb 11, 2022
@kneerunjun kneerunjun self-assigned this Feb 11, 2022
kneerunjun added a commit that referenced this issue Feb 11, 2022
@kneerunjun
refactoring for #32
fdb905d
@kneerunjun
Copy link
Contributor Author

when no relay id is selected on a schedule (non-primary) it should highlight the erreneous schedule and also indicate the error

kneerunjun added a commit that referenced this issue Feb 11, 2022
@kneerunjun
further to comment on #32
e84f79f
@kneerunjun
Copy link
Contributor Author

Edit file name editSchedsCtrl.js to a more appropriate indicative name

kneerunjun added a commit that referenced this issue Feb 11, 2022
@kneerunjun
ahead of file rename comment on #32
1b67b83
@kneerunjun
Copy link
Contributor Author

$scope.delete=function refactor the function implementation using array.prototype.findIndex()

kneerunjun added a commit that referenced this issue Feb 11, 2022
@kneerunjun
ahead of file rename comment on #32
2af636c
@kneerunjun
Copy link
Contributor Author

need to add code to submit() for posting data to api after the schedules have been modified

kneerunjun added a commit that referenced this issue Feb 12, 2022
@kneerunjun
ahead of file rename comment on #32
21ad431
@kneerunjun
Copy link
Contributor Author

The view needs to be authorized-only for all the users

kneerunjun added a commit that referenced this issue Feb 14, 2022
@kneerunjun
ahead of of comment on #32
7ea367b
kneerunjun added a commit that referenced this issue Feb 15, 2022
@kneerunjun
#32 tested can close
8cbe894
@kneerunjun
Copy link
Contributor Author

quick testing of schedule edits - now working fine can merge branch with master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kneerunjun kneerunjun

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kneerunjun