-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single Receiver mode #161
Comments
Upon discussion, the main trade-off, pros/cons are:
We will also keep the original option and let the vendor admin decide! |
Was reflecting on this a bit more: From the operator side this would be the preferred mode as the whole complication of managing and consolidating multiple keys would vanish. |
Another option could be that we use eth_signTransaction and use the tx signature as a signature that the user owns the address. For this it is important we get the trransaction before the mempool does. Also there are problems with replacement-transactions. |
@ligi just making a note of something we discussed on an earlier call -- we could use the signed transaction as a proof of wallet ownership even if the transaction gets cancelled later on? The outstanding question is how to pair multiple tickets arriving from a single wallet in case some of the payments are cancelled or sped up and the nonces of arriving transactions don't match the nonces of the signed trannsaction that the backend stores? |
Our current trade-off is to make it as easy as possible for the user (single wallet interaction) - with the drawback it is more hassle fr the operator as we have one address per order. Especially when wanting to accept DAI you end up with 2 wallet touchpoints.
But other events that e.g. use the plugin from the market after #158 might want to choose a different trade-off.
As you have 2 touchpoints when doing single receiver mode I would select 1. sign text or typed data 2. transaction on chain
Maybe only for DAI transfers. I would prefer not to walk the token approval route. With ETH you can just add it to the tx-data. Still to be considered in this scenario: refunds
The text was updated successfully, but these errors were encountered: