Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive for rule strict-effect-handlers #149

Closed
7iomka opened this issue Oct 16, 2023 · 5 comments
Closed

False positive for rule strict-effect-handlers #149

7iomka opened this issue Oct 16, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@7iomka
Copy link

7iomka commented Oct 16, 2023

image

image image

Function Unknown can lead to scope loosing in Fork API.eslint[effector/strict-effect-handlers](https://eslint.effector.dev/rules/strict-effect-handlers)

And this is not just IDE bug
image

@7iomka
Copy link
Author

7iomka commented Oct 16, 2023

Maybe this is related with updates of plugin or eslint
Versions on the left side don't have the issue.

image

@igorkamyshev
Copy link
Member

Hello! Thanks for report.

Could you please ensure that TS integration for ESLint is set up correctly? (refer to the issue #131)

I believe in this case ESLint fallen back to JS-checks which could be inaccurate and could not check that the field of object ($$editAdress.setAsDefaultFx) is Effect.

@igorkamyshev igorkamyshev added the bug Something isn't working label Oct 19, 2023
@7iomka
Copy link
Author

7iomka commented Oct 20, 2023

It cannot be reproduced — https://stackblitz.com/edit/effector-vite-react-template-dajnx8?file=tsconfig.json,src%2Fmodel.ts%3AL20,src%2Fanother-model.ts,src%2Fapplication.tsx

The culprit of the problem is @typescript-eslint/parser v6+
The change that make issue to appear in my local monorepo setup:

"@typescript-eslint/parser": "^5.59.0",
---->
"@typescript-eslint/parser": "^6.7.3",

I think this is related with this one

@igorkamyshev
Copy link
Member

It is about #144

Will be fixed 🫡

Let me close this one as duplicate

@igorkamyshev igorkamyshev closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants