Image type detection

[rande]

Should you add a check on the content type before generating an event ?

EkinoTinyPngSonataMediaBundle/src/Listener/MediaEventSubscriber.php

Line 166 in f37c137

{

[mazsudo]

At this point (in a private method of a final class), we have already check that content is a MediaInterface (inside getProvider method

EkinoTinyPngSonataMediaBundle/src/Listener/MediaEventSubscriber.php

Line 121 in 72e95f0

if (!$media instanceof MediaInterface) {

and by type hinting in publishOptimizeMessage signature). Furthermore, only media handled by providers defined in configuration and from png/jpg type (

EkinoTinyPngSonataMediaBundle/src/Listener/MediaEventSubscriber.php

Line 129 in 72e95f0

if (!\in_array($media->getExtension(), static::ALLOWED_EXTENSIONS)) {

) will launch an event.

Do you think to an additional check?