Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge case in v3.0.0 worked correctly in v2.5.1 #1134

Open
docEdub opened this issue Jan 14, 2025 · 1 comment
Open

Edge case in v3.0.0 worked correctly in v2.5.1 #1134

docEdub opened this issue Jan 14, 2025 · 1 comment

Comments

@docEdub
Copy link

docEdub commented Jan 14, 2025

I have an edge case in Babylon.js that worked correctly in manifold-3d v2.5.1 but adds extra edges when switching to manifold-3d v3.0.0.

I've repro'd the issue in a Babylon.js playground:
https://playground.babylonjs.com/?manifold=3#1DWRFP#3
Screenshot 2025-01-14 152623

Using the older version of manifold-3d shows the expected result:
https://playground.babylonjs.com/?manifold=2#1DWRFP#3
Screenshot 2025-01-14 152838

Apologies for not using the manifold-3d playground, but I did not see a way to show edges and normals there. I exposed the manifold-3d types towards the end of the Babylon playground at line 63, and logged out the result mesh vertProperties as an example if it helps.

I tried comparing the resulting vertices from each version, but the diff is too varied to show the issue immediately, so I'm hoping some expert eyes will take a look.

@elalish
Copy link
Owner

elalish commented Jan 20, 2025

Is the resulting object incorrect? We don't guarantee that e.g. the number of verts, edges, etc are consistent from version to version, as there are many correct answers. Does the volume or surface area change in a noticeable way? That's a better way to test regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants