Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Investigation] CI Check for Minstacked Integration Schema Changes #4161

Open
Mikaayenson opened this issue Oct 16, 2024 · 0 comments
Open
Assignees
Labels

Comments

@Mikaayenson
Copy link
Contributor

Repository Feature

Core Repo - (rule management, validation, testing, lib, cicd, etc.)

Problem Description

Currently when we update the integration schemas for our rules and try to release new content, our automation workflows break if the integration introduces a new min stack. We then have to min stack our rules (e.g. #4156) but this is after we've tried to version lock our rules and noticed double bumps.

We can potentially catch these changes earlier.

Desired Solution

By looking at the response from https://epr.elastic.co/search?prerelease=true we can potentially alert when the conditions.kibana.version changes for a given integration name.

Ideally, per PR, we could:

  1. Load the rules in the PR
  2. Pull all the integrations used in the rules
  3. Pull the conditions.kibana.version in the manifest that we have (assuming it has the versions as well) and compare to see if the version has changed.

We probably wouldn't want this to be a unit test, but rather a CLI command called in a CI workflow that runs only for our PRs. This way the PR CI check will fail and let the user know immediately that the rule needs to be minstacked.

Considered Alternatives

We can also exploring how to modify our internal logic to ignore when certain fields have changed so that we dont have to minstack our rules unecessarilily.

Additional Context

#4155

@shashank-elastic shashank-elastic self-assigned this Oct 22, 2024
@shashank-elastic shashank-elastic changed the title [FR] CI Check for Minstacked Integration Schema Changes [Investigation] CI Check for Minstacked Integration Schema Changes Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants